Skip to content

Commit

Permalink
Merge pull request #4363 from mavasani/FixesForConvertedAnalyzers
Browse files Browse the repository at this point in the history 
Remove 'isReportedAtCompilationEnd: true' for compilation end analyzers ported to symbol start/end analyzers
  • Loading branch information
@mavasani
mavasani committed Oct 23, 2020
2 parents 5c77216 + 6c930f9 commit 5a80d62
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 32 deletions.
12 changes: 4 additions & 8 deletions src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1387,8 +1387,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down Expand Up @@ -1556,8 +1555,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand All @@ -1578,8 +1576,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down Expand Up @@ -3132,8 +3129,7 @@
"PortedFromFxCop",
"Dataflow",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down
9 changes: 3 additions & 6 deletions src/Microsoft.CodeQuality.Analyzers/Microsoft.CodeQuality.Analyzers.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1372,8 +1372,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down Expand Up @@ -1541,8 +1540,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand All @@ -1563,8 +1561,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -825,8 +825,7 @@
"PortedFromFxCop",
"Dataflow",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down
3 changes: 1 addition & 2 deletions ...nalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/AvoidUnusedPrivateFields.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ public sealed class AvoidUnusedPrivateFieldsAnalyzer : DiagnosticAnalyzer
RuleLevel.Disabled, // Need to figure out how to handle runtime only references. We also have an implementation in the IDE.
description: s_localizableDescription,
isPortedFxCopRule: true,
isDataflowRule: false,
isReportedAtCompilationEnd: true);
isDataflowRule: false);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);

Expand Down
3 changes: 1 addition & 2 deletions ...tAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/ReviewUnusedParameters.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public sealed class ReviewUnusedParametersAnalyzer : DiagnosticAnalyzer
RuleLevel.Disabled, // We have an implementation in IDE.
description: s_localizableDescription,
isPortedFxCopRule: true,
isDataflowRule: false,
isReportedAtCompilationEnd: true);
isDataflowRule: false);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);

Expand Down
3 changes: 1 addition & 2 deletions ...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/MarkMembersAsStatic.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ public sealed class MarkMembersAsStaticAnalyzer : DiagnosticAnalyzer
RuleLevel.IdeSuggestion,
description: s_localizableDescription,
isPortedFxCopRule: true,
isDataflowRule: false,
isReportedAtCompilationEnd: true);
isDataflowRule: false);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);

Expand Down
3 changes: 1 addition & 2 deletions ...NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DisposableFieldsShouldBeDisposed.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public sealed class DisposableFieldsShouldBeDisposed : DiagnosticAnalyzer
RuleLevel.Disabled,
description: s_localizableDescription,
isPortedFxCopRule: true,
isDataflowRule: true,
isReportedAtCompilationEnd: true);
isDataflowRule: true);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);

Expand Down
12 changes: 4 additions & 8 deletions src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1834,8 +1834,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down Expand Up @@ -2086,8 +2085,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand All @@ -2108,8 +2106,7 @@
"tags": [
"PortedFromFxCop",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down Expand Up @@ -2782,8 +2779,7 @@
"PortedFromFxCop",
"Dataflow",
"Telemetry",
"EnabledRuleInAggressiveMode",
"CompilationEnd"
"EnabledRuleInAggressiveMode"
]
}
},
Expand Down

0 comments on commit 5a80d62

Please sign in to comment.