Enabled logging analyzer on new repo

[maryamariyan]

The dotnet/extensions code: https://github.com/dotnet/extensions/tree/master/src/Logging/Logging.Analyzers

cc: @mavasani @sharwell @pgovind

[maryamariyan]

Got caught up with conflicts from diagnostics on other PRs getting merged and me having to change my diagnostic numbers on this PR.

Currently checking to see if the CI build is successful before pushing up a WIP commit trying to address using operation analysis instead of syntax analysis.

Once that is done, I will address the remaining feedback.

[codecov]

Codecov Report

Merging #5244 (cf7cc42) into release/6.0.1xx (d36599d) will decrease coverage by 0.02%.
The diff coverage is 81.87%.

@@                 Coverage Diff                 @@
##           release/6.0.1xx    #5244      +/-   ##
===================================================
- Coverage            95.62%   95.60%   -0.03%     
===================================================
  Files                 1233     1236       +3     
  Lines               283449   283895     +446     
  Branches             16968    17032      +64     
===================================================
+ Hits                271052   271418     +366     
- Misses               10108    10179      +71     
- Partials              2289     2298       +9     

[maryamariyan]

the MemberData test cases for CA2255IsProducedForFormatArgumentCountMismatch fail on the latest update. Looking into it.

[Youssef1313]

Since there is no language specific logic now. I believe this can be moved up from CSharp to Core without any extra work other than unit tests.

[maryamariyan]

The test failures still need looking into. @sharwell and I plan on looking at this again today.

[Youssef1313]

@maryamariyan I'm not seeing test failures in CI. The failure in CI is due to auto-generated files being outdated. Can you run msbuild /t:pack /v:m in the repository root? This should update the following files:

• src\NetAnalyzers\Microsoft.CodeAnalysis.NetAnalyzers.md
• src\NetAnalyzers\Microsoft.CodeAnalysis.NetAnalyzers.sarif

[maryamariyan]

The PR is ready for review :)

[maryamariyan]

@maryamariyan if this is going to be enabled by default in the .NET 6 SDK I suggest we add a performance test for it here: https://github.com/dotnet/roslyn-analyzers/tree/main/src/PerformanceTests/Tests/Enabled this can happen in a follow up PR in the RC1/RC2 timeframe

OK, will address in a follow up PR

[buyaa-n]

for future reference here is a sample set exercising all 5 diagnostics assuming all are enabled:

The message structure looks good to me, but the Named holes sounds weird, not sure that is the term used for C# cc @terrajobst

[maryamariyan]

The message structure looks good to me, but the Named holes sounds weird, not sure that is the term used for C# cc @terrajobst

I renamed to "named placeholder" from "named hole", since that works as well

[terrajobst]

I renamed to "named placeholder" from "named hole", since that works as well

💯