-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable pre-built detection #6610
Changes from all commits
40309fa
dcd718b
786d2e5
9e5466e
8a9d2ba
b18a79a
2292a1d
dd373c9
622c6d1
30c6b2d
b3de7f6
397fab4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,16 @@ | ||
<!-- See aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. --> | ||
<UsageData> | ||
<IgnorePatterns> | ||
<UsagePattern IdentityGlob="*/*" /> | ||
<UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*" /> | ||
|
||
<!-- This packages contain functionality that is executed in the build --> | ||
<UsagePattern IdentityGlob="Microsoft.Net.Compilers.Toolset/*" /> | ||
<UsagePattern IdentityGlob="System.Composition*/*" /> | ||
|
||
<!-- This is the version of Microsoft.CodeAnalysis used for tooling executed in repo source-build, | ||
as well as unit tests. --> | ||
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis*/*4.6.0-1.final*" /> | ||
<!-- Dependency of Microsoft.CodeAnalysis.Common 4.6.0-1.final --> | ||
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Analyzers/*3.3.4*" /> | ||
</IgnorePatterns> | ||
</UsageData> | ||
</UsageData> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,22 +5,39 @@ | |
<Uri>https://github.com/dotnet/roslyn</Uri> | ||
<Sha>66a912c9463eebe832cf742d2fe8bb2e1a4600ec</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23305.4"> | ||
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri> | ||
<Sha>540ccf1a6831993d8ac8bf10bdfd3fde93ecee2e</Sha> | ||
<SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" /> | ||
</Dependency> | ||
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-externals" Version="8.0.0-alpha.1.23214.1"> | ||
<Uri>https://github.com/dotnet/source-build-externals</Uri> | ||
<Sha>de4dda48d0cf31e13182bc24107b2246c61ed483</Sha> | ||
<SourceBuild RepoName="source-build-externals" ManagedOnly="true" /> | ||
</Dependency> | ||
</ProductDependencies> | ||
<ToolsetDependencies> | ||
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.23269.1"> | ||
<Uri>https://github.com/dotnet/arcade</Uri> | ||
<Sha>fb6291b40fa4334dbd167e2071953e83cc8b9fdc</Sha> | ||
<SourceBuild RepoName="arcade" ManagedOnly="true" /> | ||
</Dependency> | ||
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.5.0"> | ||
<Uri>https://github.com/dotnet/roslyn</Uri> | ||
<Sha>6a5a63bbc9f4449d9bd1e95a8f9624939c3ccdc3</Sha> | ||
<!-- Used in repo tooling. Not updated automatically --> | ||
<Dependency Name="System.Composition" Version="8.0.0-preview.4.23259.5"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>84a3d0e37e8f22b0b55f8bf932cb788b2bdd728f</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="4.5.0"> | ||
<Uri>https://github.com/dotnet/roslyn</Uri> | ||
<Sha>6a5a63bbc9f4449d9bd1e95a8f9624939c3ccdc3</Sha> | ||
<Dependency Name="Microsoft.SourceLink.GitHub" Version="8.0.0-beta.23252.2" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk"> | ||
<Uri>https://github.com/dotnet/sourcelink</Uri> | ||
<Sha>54eb3b811c57f5e94617d31a102fc9cb664ccdd5</Sha> | ||
<SourceBuild RepoName="sourcelink" ManagedOnly="true" /> | ||
</Dependency> | ||
<Dependency Name="Microsoft.CodeAnalysis.VisualBasic.CodeStyle" Version="4.5.0"> | ||
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23266.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk"> | ||
<Uri>https://github.com/dotnet/xliff-tasks</Uri> | ||
<Sha>9e7fbcab4e5275f63c0cd37553ba426de9194309</Sha> | ||
<SourceBuild RepoName="xliff-tasks" ManagedOnly="true" /> | ||
</Dependency> | ||
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.5.0"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This package is marked as pre-built and we cannot utilize a ref assembly for it. Bumping the package to the latest version causes a built-time exception:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll need to fix the compile error. Because these 3 packages contain functionality that has to execute, them must either come from previously source-built, or from roslyn's build. Pinning to a stable version here works, but will probably mean more instability in product source build. Updating regularly from roslyn means more dependency flow and channel/subscription management. I propose that we keep as-is for now, and if we see frequent breaks, we should move to change this to an actively updated dependency. |
||
<Uri>https://github.com/dotnet/roslyn</Uri> | ||
<Sha>6a5a63bbc9f4449d9bd1e95a8f9624939c3ccdc3</Sha> | ||
</Dependency> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
|
||
<!-- RS0026: Avoid public API overloads with differences in optional parameters --> | ||
<NoWarn>$(NoWarn);RS0026</NoWarn> | ||
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisVersionForCodeAnalysisAnalyzers)</MicrosoftCodeAnalysisVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in version, 3.3.1 |
||
</PropertyGroup> | ||
<Import Project="..\Utilities\Compiler\Analyzer.Utilities.projitems" Label="Shared" /> | ||
<Import Project="..\Utilities\FlowAnalysis\FlowAnalysis.Utilities.projitems" Label="Shared" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFramework>netstandard2.0</TargetFramework> | ||
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisVersionForCodeAnalysisAnalyzers)</MicrosoftCodeAnalysisVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in version, 3.3.1 |
||
</PropertyGroup> | ||
<ItemGroup> | ||
<ProjectReference Include="..\Core\Microsoft.CodeAnalysis.Analyzers.csproj" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
Restore would conclude that there is a cyclic dependency between Microsoft.CodeAnalysis and Microsoft.CodeAnalysis.Analyzers. | ||
--> | ||
<PackageId>*$(MSBuildProjectFile)*</PackageId> | ||
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisVersionForCodeAnalysisAnalyzers)</MicrosoftCodeAnalysisVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in version, 3.3.1 |
||
</PropertyGroup> | ||
<ItemGroup> | ||
<Compile Include="..\..\Microsoft.CodeAnalysis.BannedApiAnalyzers\Core\DocumentationCommentIdParser.cs" Link="DocumentationCommentIdParser.cs" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFramework>netstandard2.0</TargetFramework> | ||
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisVersionForCodeAnalysisAnalyzers)</MicrosoftCodeAnalysisVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in version, 3.3.1 |
||
</PropertyGroup> | ||
<ItemGroup> | ||
<ProjectReference Include="..\Core\Microsoft.CodeAnalysis.Analyzers.csproj" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFramework>netstandard2.0</TargetFramework> | ||
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisVersionForNetAnalyzers)</MicrosoftCodeAnalysisVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in version, 3.3.1. Added new property for this. |
||
</PropertyGroup> | ||
<ItemGroup> | ||
<ProjectReference Include="..\Core\Microsoft.CodeAnalysis.NetAnalyzers.csproj" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
<PackageId>*$(MSBuildProjectFile)*</PackageId> | ||
<RootNamespace></RootNamespace> | ||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisVersionForNetAnalyzers)</MicrosoftCodeAnalysisVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in version, 3.3.1. Added new property for this. |
||
</PropertyGroup> | ||
<ItemGroup> | ||
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.CSharp.NetAnalyzers" /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.