Move to latest code style analyzer package

[mavasani]

Also fix the IDExxxx violations from the new package.

Recommended to review commit-by-commit

[codecov]

Codecov Report

Merging #6685 (87bca54) into main (2f0301e) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6685      +/-   ##
==========================================
- Coverage   96.39%   96.38%   -0.01%     
==========================================
  Files        1379     1379              
  Lines      322416   322416              
  Branches    10461    10462       +1     
==========================================
- Hits       310784   310771      -13     
+ Misses       9139     9137       -2     
- Partials     2493     2508      +15     

[sharwell]

Please disable IDE0290 and revert the associated changes. The rest looks fine.

[mavasani]

Please disable IDE0290 and revert the associated changes. The rest looks fine.

Tagging @CyrusNajmabadi as well. I thought the idea is to dogfood the new analyzer/fixer for primary constructors. Are you suggesting the revert due to style preferences or the fact that there could still be bugs in the new feature/analyzer/fixer?

[CyrusNajmabadi]

I would def appreciate dogfooding. But if you do run into issues, don't fix them, just revert that case and let me know. :-)

[sharwell]

Are you suggesting the revert due to style preferences or the fact that there could still be bugs in the new feature/analyzer/fixer?

Strictly due to style preference. The analyzer/fixer may work fine, but I have no interest in using it.

[mavasani]

@sharwell Reverted the primary constructor style changes. Please take a look.