fix(CA2208): false positive when message start with parameter name followed by punctuation #7065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowed by punctuation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7065 +/- ##
==========================================
- Coverage 96.43% 96.43% -0.01%
==========================================
Files 1412 1412
Lines 336962 337001 +39
Branches 11143 11144 +1
==========================================
+ Hits 324956 324971 +15
- Misses 9204 9225 +21
- Partials 2802 2805 +3 |
|
@stephentoub PTAL |
buyaa-n
approved these changes
Dec 11, 2023
|
CC @jeffhandley @artl93 we might want to port the fix into 8.0 as it was regression introduced with https://github.com/dotnet/roslyn-analyzers/pull/6553/files and causing false positive warnings |
|
/backport to release/8.0.2xx |
|
Started backporting to release/8.0.2xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/7185209527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #6863