[release/8.0.2xx] fix(CA2208): false positive when message start with parameter name followed by punctuation #7092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…llowed by punctuation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/8.0.2xx #7092 +/- ##
===================================================
- Coverage 96.39% 96.39% -0.01%
===================================================
Files 1402 1402
Lines 332264 332297 +33
Branches 11065 11066 +1
===================================================
+ Hits 320288 320302 +14
- Misses 9204 9220 +16
- Partials 2772 2775 +3 |
buyaa-n
requested review from
jeffhandley,
carlossanlop,
artl93 and
mavasani
buyaa-n
added
the
servicing-consider
jeffhandley
approved these changes
Dec 12, 2023
carlossanlop
added
servicing-approved
and removed
servicing-consider
|
Approved by Tactics in today's meeting. |
|
Please don't merge yet. I need some clarity on whether we're ok in continuing merging backports to the old 8.0.2xx branch, or if we have to wait for 8.0.3xx to be snapped and then retarget this PR to that branch. |
|
Ok got clarity. The 8.0.2xx branch is still open for changes until Jan 5th. We can get this merged and we can flow it via darc to the sdk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7065 to release/8.0.2xx
/cc @buyaa-n @HenryZhang-ZHY
Customer Impact
Several customers reported this regression: #6863, #6925, #7056. The enhancement we made in 8.0 Relax name validation in CA2208 had a side effect that caused the regression that introduces new false positive diagnostics for the case mentioned in the issue. In case user set warn as error for the CA2208 the new diagnostics could break the build.
Testing
A unit test that reproduces the issue is added with the PR
Risk
Very low, the fix is clear and straight forward, don't expect it cause any bad side effect.