[release/8.0.2xx] fix(CA2208): false positive when message start with parameter name followed by punctuation #7092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7065 to release/8.0.2xx
/cc @buyaa-n @HenryZhang-ZHY
Customer Impact
Several customers reported this regression: #6863, #6925, #7056. The enhancement we made in 8.0 Relax name validation in CA2208 had a side effect that caused the regression that introduces new false positive diagnostics for the case mentioned in the issue. In case user set warn as error for the CA2208 the new diagnostics could break the build.
Testing
A unit test that reproduces the issue is added with the PR
Risk
Very low, the fix is clear and straight forward, don't expect it cause any bad side effect.