Collection expressions: report specific conversion errors from overlo…

…ad resolution
dotnet · May 2, 2024 · 0eb7540 · 0eb7540
1 parent 0c8ac4c
commit 0eb7540
Show file tree

Hide file tree

Showing 3 changed files with 154 additions and 43 deletions.
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs b/src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs
@@ -1512,7 +1512,7 @@ internal bool TryGetCollectionIterationType(SyntaxNode syntax, TypeSymbol collec
             { WasCompilerGenerated = node.IsParamsArrayOrCollection, IsParamsArrayOrCollection = node.IsParamsArrayOrCollection };
         }
 
-        private void GenerateImplicitConversionErrorForCollectionExpression(
+        internal void GenerateImplicitConversionErrorForCollectionExpression(
             BoundUnconvertedCollectionExpression node,
             TypeSymbol targetType,
             BindingDiagnosticBag diagnostics)

diff --git a/...Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/OverloadResolutionResult.cs b/...Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/OverloadResolutionResult.cs
@@ -1231,6 +1231,10 @@ private static bool HadLambdaConversionError(BindingDiagnosticBag diagnostics, A
                 {
                     // a diagnostic has been reported by ReportDelegateOrFunctionPointerMethodGroupDiagnostics
                 }
+                else if (argument.Kind == BoundKind.UnconvertedCollectionExpression)
+                {
+                    binder.GenerateImplicitConversionErrorForCollectionExpression((BoundUnconvertedCollectionExpression)argument, parameterType, diagnostics);
+                }
                 else
                 {
                     // There's no symbol for the argument, so we don't need a SymbolDistinguisher.