Merge pull request #62898 from antomys/dev/antomys/completionoptions-…

…rename Renamed `ShouldShowItemsFromUnimportNamspaces` to `ShouldShowItemsFromUnimportedNamespaces`
dotnet · Jul 25, 2022 · 4bbd4bf · 4bbd4bf
2 parents 5fb47b1 + f2207c4
commit 4bbd4bf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/EditorFeatures/Core/IntelliSense/AsyncCompletion/CompletionSource.cs b/src/EditorFeatures/Core/IntelliSense/AsyncCompletion/CompletionSource.cs
@@ -271,7 +271,7 @@ internal sealed class CompletionSource : IAsyncExpandingCompletionSource
 
                 var sessionData = CompletionSessionData.GetOrCreateSessionData(session);
 
-                if (!options.ShouldShowItemsFromUnimportNamspaces())
+                if (!options.ShouldShowItemsFromUnimportedNamespaces())
                 {
                     // No need to trigger expanded providers at all if the feature is disabled, just trigger core providers and return;
                     var (context, list) = await GetCompletionContextWorkerAsync(document, trigger, triggerLocation,

diff --git a/src/Features/Core/Portable/Completion/CompletionOptions.cs b/src/Features/Core/Portable/Completion/CompletionOptions.cs
@@ -44,7 +44,7 @@ public RecommendationServiceOptions ToRecommendationServiceOptions()
         /// This takes into consideration the experiment we are running in addition to the value
         /// from user facing options.
         /// </summary>
-        public bool ShouldShowItemsFromUnimportNamspaces()
+        public bool ShouldShowItemsFromUnimportedNamespaces()
         {
             // Don't trigger import completion if the option value is "default" and the experiment is disabled for the user. 
             return ShowItemsFromUnimportedNamespaces ?? TypeImportCompletion;

diff --git a/...ortable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs b/...ortable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs
@@ -41,7 +41,7 @@ public Task NotifyCommittingItemAsync(Document document, CompletionItem item, ch
 
         public override async Task ProvideCompletionsAsync(CompletionContext completionContext)
         {
-            if (!completionContext.CompletionOptions.ShouldShowItemsFromUnimportNamspaces())
+            if (!completionContext.CompletionOptions.ShouldShowItemsFromUnimportedNamespaces())
                 return;
 
             var cancellationToken = completionContext.CancellationToken;