Skip to content

Commit

Permalink
Reserve feature branch error codes (#45567)
Browse files Browse the repository at this point in the history
  • Loading branch information
RikkiGibson committed Jul 1, 2020
1 parent a2e42f8 commit 6ff210c
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 4 deletions.
16 changes: 12 additions & 4 deletions src/Compilers/CSharp/Portable/Errors/ErrorCode.cs
Expand Up @@ -1771,7 +1771,7 @@ internal enum ErrorCode
ERR_NoOutputDirectory = 8771,
ERR_StdInOptionProvidedButConsoleInputIsNotRedirected = 8772,

// available 8773
ERR_FeatureNotAvailableInVersion9 = 8773,

WRN_MemberNotNull = 8774,
WRN_MemberNotNullWhen = 8775,
Expand Down Expand Up @@ -1818,15 +1818,23 @@ internal enum ErrorCode
ERR_AddressOfMethodGroupInExpressionTree = 8810,
ERR_CannotConvertAddressOfToDelegate = 8811,
ERR_AddressOfToNonFunctionPointer = 8812,
ERR_FeatureNotAvailableInVersion9 = 8813,

// Codes 8813, 8814, 8815, 8816 used by features/module-initializers
ERR_8813 = 8813, // used by features/module-initializers

ERR_8814 = 8814, // used by features/module-initializers

ERR_8815 = 8815, // used by features/module-initializers

ERR_8816 = 8816, // used by features/module-initializers

ERR_PartialMethodReturnTypeDifference = 8817,
ERR_PartialMethodRefReturnDifference = 8818,
WRN_NullabilityMismatchInReturnTypeOnPartial = 8819,

// Codes 8820, 8821 used by features/static-lambdas

ERR_8820 = 8820, // used by features/static-lambdas

ERR_8821 = 8821, // used by features/static-lambdas

ERR_ExpressionTreeContainsWithExpression = 8849,
ERR_BadRecordDeclaration = 8850,
Expand Down
Expand Up @@ -31,6 +31,15 @@ public void Resources()
ErrorCode.Void,
ErrorCode.Unknown,
ErrorCode.WRN_ALinkWarn, // Not reported, but retained to allow configuring class of related warnings. See CSharpDiagnosticFilter.Filter.

// The following error codes are reserved by feature branches
ErrorCode.ERR_8813,
ErrorCode.ERR_8814,
ErrorCode.ERR_8815,
ErrorCode.ERR_8816,

ErrorCode.ERR_8820,
ErrorCode.ERR_8821,
};
foreach (ErrorCode code in Enum.GetValues(typeof(ErrorCode)))
{
Expand Down

0 comments on commit 6ff210c

Please sign in to comment.