Skip to content

Commit

Permalink
Remove 'mangleName' parameter in PENamedTypeSymbolNonGeneric (#62813)
Browse files Browse the repository at this point in the history
  • Loading branch information
RikkiGibson committed Jul 21, 2022
1 parent d614564 commit 9a67030
Showing 1 changed file with 8 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,11 @@ internal bool IsDefaultValue()

GetGenericInfo(moduleSymbol, handle, out genericParameterHandles, out arity, out mrEx);

bool mangleName;
PENamedTypeSymbol result;

if (arity == 0)
{
result = new PENamedTypeSymbolNonGeneric(moduleSymbol, containingNamespace, handle, emittedNamespaceName, out mangleName);
result = new PENamedTypeSymbolNonGeneric(moduleSymbol, containingNamespace, handle, emittedNamespaceName);
}
else
{
Expand All @@ -193,8 +192,7 @@ internal bool IsDefaultValue()
handle,
emittedNamespaceName,
genericParameterHandles,
arity,
out mangleName);
arity);
}

if (mrEx != null)
Expand Down Expand Up @@ -240,12 +238,11 @@ private static void GetGenericInfo(PEModuleSymbol moduleSymbol, TypeDefinitionHa
arity = (ushort)(metadataArity - containerMetadataArity);
}

bool mangleName;
PENamedTypeSymbol result;

if (metadataArity == 0)
{
result = new PENamedTypeSymbolNonGeneric(moduleSymbol, containingType, handle, null, out mangleName);
result = new PENamedTypeSymbolNonGeneric(moduleSymbol, containingType, handle, null);
}
else
{
Expand All @@ -255,8 +252,7 @@ private static void GetGenericInfo(PEModuleSymbol moduleSymbol, TypeDefinitionHa
handle,
null,
genericParameterHandles,
arity,
out mangleName);
arity);
}

if (mrEx != null || metadataArity < containerMetadataArity)
Expand Down Expand Up @@ -2415,9 +2411,8 @@ private sealed class PENamedTypeSymbolNonGeneric : PENamedTypeSymbol
PEModuleSymbol moduleSymbol,
NamespaceOrTypeSymbol container,
TypeDefinitionHandle handle,
string emittedNamespaceName,
out bool mangleName) :
base(moduleSymbol, container, handle, emittedNamespaceName, 0, out mangleName)
string emittedNamespaceName) :
base(moduleSymbol, container, handle, emittedNamespaceName, 0, out _)
{
}

Expand Down Expand Up @@ -2487,15 +2482,13 @@ private sealed class PENamedTypeSymbolGeneric : PENamedTypeSymbol
TypeDefinitionHandle handle,
string emittedNamespaceName,
GenericParameterHandleCollection genericParameterHandles,
ushort arity,
out bool mangleName
)
ushort arity)
: base(moduleSymbol,
container,
handle,
emittedNamespaceName,
arity,
out mangleName)
out bool mangleName)
{
Debug.Assert(genericParameterHandles.Count > 0);
_arity = arity;
Expand Down

0 comments on commit 9a67030

Please sign in to comment.