Skip to content

Commit

Permalink
Fix build warnings observed locally
Browse files Browse the repository at this point in the history
  • Loading branch information
sharwell committed May 20, 2024
1 parent ea35f7c commit e872eb4
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
1 change: 1 addition & 0 deletions eng/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies.net472" Version="1.0.3" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies.net461" Version="1.0.3" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies.net451" Version="1.0.3" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies.net45" Version="1.0.3" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies.net40" Version="1.0.3" />
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies.net20" Version="1.0.3" />
<PackageVersion Include="System.Buffers" Version="4.5.1" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,10 @@

<MSBuild Projects="@(ProjectToPublish)" Targets="Pack" BuildInParallel="true" />
</Target>

<!--
Make sure the _GetPackageFiles target exists, since it is always expected for design time builds, but only
defined when ImportNuGetBuildTasksPackTargetsFromSdk is true.
-->
<Target Name="_GetPackageFiles" />
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</ItemGroup>
</Target>

<Target Name="GenerateFilteredReferenceAssemblies" BeforeTargets="CoreCompile" DependsOnTargets="_CalculateFilteredReferenceAssembliesInputsAndOutputs" Inputs="@(_InputFile)" Outputs="@(_OutputFile)">
<Target Name="GenerateFilteredReferenceAssemblies" Condition="Exists('$(ArtifactsBinDir)SemanticSearch.BuildTask\$(Configuration)\$(_BuildTaskTfm)\SemanticSearch.BuildTask.dll')" BeforeTargets="CoreCompile" DependsOnTargets="_CalculateFilteredReferenceAssembliesInputsAndOutputs" Inputs="@(_InputFile)" Outputs="@(_OutputFile)">

<MakeDir Directories="$(_OutputDir)" />
<Microsoft.CodeAnalysis.Tools.GenerateFilteredReferenceAssembliesTask References="@(_InputReference)" ApiSets="@(ApiSet)" OutputDir="$(_OutputDir)" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
<Project Sdk="Microsoft.Build.Traversal">
<PropertyGroup>
<TargetFrameworks>net472</TargetFrameworks>
<TargetFrameworks>net472</TargetFrameworks>
<ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies.net45" />
</ItemGroup>

<!--
This build project is used to allow CI to only build the projects required to build and run integration tests.
Everything else (for example other unit test projects) are excluded to speed up the build time.
Expand Down

0 comments on commit e872eb4

Please sign in to comment.