Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoslynInsertionTool: better way to discover Willow components #13593

Closed
tmat opened this issue Sep 3, 2016 · 1 comment
Closed

RoslynInsertionTool: better way to discover Willow components #13593

tmat opened this issue Sep 3, 2016 · 1 comment

Comments

@tmat
Copy link
Member

tmat commented Sep 3, 2016

Currently RIT fetches a TFS log file zip from the target build, finds a log file containing "Upload VSTS Drop" name (corresponding to Microbuild task called "Upload VSTS Drop"), parses the file for https://.*vsman pattern and then uses the URLs found this way. This is very fragile and full of assumptions that need to be true across all repos we insert from. Also, if the URL is not found NRE is thrown.

We should have a more robust way of doing this.

@jasonmalinowski
Copy link
Member

It's worked fine for two years....(famous last words)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants