Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rule CA1822 (Mark members as static) on Roslyn.sln #25132

Open
mavasani opened this issue Feb 28, 2018 · 2 comments · May be fixed by #61453
Open

Enable rule CA1822 (Mark members as static) on Roslyn.sln #25132

mavasani opened this issue Feb 28, 2018 · 2 comments · May be fixed by #61453
Labels
Area-Analyzers Area-Infrastructure

Comments

@mavasani
Copy link
Member

Cause: A member that does not access instance data is not marked as static (Shared in Visual Basic).
See rule documentation

We recently enabled this rule by default in analyzer package, and this seem to have lot of violations in Roslyn.sln. We probably want a code fix with fix all to bulk fix these violations and enable this rule. For now, we are turning off this rule in Roslyn_BuildRules.ruleset. This issue tracks enabling it.
@Youssef1313 Youssef1313 linked a pull request May 23, 2022 that will close this issue
Draft
@CyrusNajmabadi
Copy link
Member

@mavasani anything left to do here?

@mavasani
Copy link
Member Author

We have a draft PR from @Youssef1313 that should complete this work: #61453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Analyzers Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable CA1822 (make static) Youssef1313/roslyn
2 participants
@CyrusNajmabadi @mavasani