Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOperation: ITupleBinaryOperation could expose more information #25435

Open
jcouv opened this issue Mar 12, 2018 · 3 comments
Open

IOperation: ITupleBinaryOperation could expose more information #25435

jcouv opened this issue Mar 12, 2018 · 3 comments
Assignees
@jcouv
Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation _Product-level triaged
Milestone
Backlog

Comments

@jcouv
Copy link
Member

jcouv commented Mar 12, 2018

Currently, we only expose a LeftOperand, a RightOperand and an OperatorKind.
We could also expose an IsLifted, an IsChecked, and also details about the element-wise binary operators.
@jcouv jcouv added Concept-API This issue involves adding, removing, clarification, or modification of an API. Area-Compilers Feature - IOperation IOperation labels Mar 12, 2018
@jcouv jcouv mentioned this issue Mar 12, 2018
Merged
@CyrusNajmabadi
Copy link
Member

and also details about the element-wise binary operators.

This seems like one of the most relevant pieces of info. If i'm converting tuples, i'll often want to know how hte individual parts got converted. Thanks!

@jcouv
Copy link
Member Author

jcouv commented Mar 12, 2018

The conversions are already available via LeftOperand and RightOperand. For instance in (1, 1) == (2L, 2L), the left will should conversions to long.
The OperatorMethod used for each element-wise conversion is what's missing.

@CyrusNajmabadi
Copy link
Member

ah, gotcha. Thanks!

@jinujoseph jinujoseph added this to the 16.0 milestone Jun 21, 2018
@jaredpar jaredpar added the Bug label Aug 30, 2018
@jcouv jcouv modified the milestones: 16.0, 16.1, 16.2 Apr 18, 2019
@jcouv jcouv modified the milestones: 16.2, 16.3, Backlog Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation _Product-level triaged
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jaredpar @CyrusNajmabadi @jinujoseph @jcouv