Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to Type / Go to Implementation for Libraries which are not part of your solution #25472

Open
jinujoseph opened this issue Mar 14, 2018 · 6 comments
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@jinujoseph
Copy link
Contributor

Reported by Michael Sterenberg
Navigation to recompiled assembly is enabled

Example:
We are using an interface that is defined in a library, e.g. ILogger.
I can decompile the ILogger but I don’t know which class or classes implement this interface: ConsoleLogger, SeriLogger, MDMLogger, AggregatedLogger, etc…
I should be able to look for all the implementations of the interface, even look for referenced libraries as well.

VS does this but only for classes that are defined in the solution.

@jinujoseph jinujoseph added this to the Unknown milestone Mar 14, 2018
@jinujoseph
Copy link
Contributor Author

Tracked also by editor team link

@sharwell
Copy link
Member

@sharwell sharwell added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Aug 14, 2020
@Camios
Copy link

Camios commented Aug 16, 2020

Wow open for over two years. How is this a 'Feature Request' - surely it is a defect?

@CyrusNajmabadi
Copy link
Member

@Camios it's a feature request because it's asking for new functionality that has not been supported before. Note: this is 'help wanted'. So we would take a community PR here if you're interested in contributing :)

@Camios
Copy link

Camios commented Aug 17, 2020

@CyrusNajmabadi, interesting, from my perspective VS has a feature 'go to implementation' and it is failing that task. The implementations are 'available' - the build tools and runtime are aware of the interface's implementations. If you create an instance of one of the implementations and assign it to a variable of the interface type, then Intellisense(?) is okay with the assignment so it is aware of at least that particular implementation if not more/all.

@CyrusNajmabadi
Copy link
Member

The implementations are 'available'

Yes. I certainly think the impl of this feature could be updated to support this concept. My position is not that it's impossible, or out of scope. However, it's new work and new functionality that would need to be created, and that's why it's a feature-request, not a bug.

We'd need a way to index this information and then find it. We would also likely need to beef up the UI a lot as it would likely be undesirable to necessarily see hundreds to thousands of new results show up when performing one of these operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

No branches or pull requests

4 participants