Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No IntelliSense suggestion for readonly struct #26120

Closed
huoyaoyuan opened this issue Apr 12, 2018 · 5 comments · Fixed by #26186
Closed

No IntelliSense suggestion for readonly struct #26120

huoyaoyuan opened this issue Apr 12, 2018 · 5 comments · Fixed by #26186
Assignees
Labels
Area-IDE Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@huoyaoyuan
Copy link
Member

huoyaoyuan commented Apr 12, 2018

Version checked: 15.6.6, 15.7 Preview 3

Keyword readonly should be available everywhere that struct is available, and only struct allowed after it?

@huoyaoyuan huoyaoyuan changed the title No IntelliSense infomation for readonly struct No IntelliSense suggestion for readonly struct Apr 12, 2018
@jcouv
Copy link
Member

jcouv commented Apr 15, 2018

@huoyaoyuan I didn't understand the issue.
Please describe what you're typing, what actual completion was provided and how it differed from what you expected. The issue you opened sounds like a question and it is not clear what (if anything) needs to be done to fix it.
Thanks

@jcouv jcouv added Area-IDE Need More Info The issue needs more information to proceed. labels Apr 15, 2018
@huoyaoyuan
Copy link
Member Author

@jcouv
Supposing public readonly struct A in namespace context, when I've typed public re, I hope the keyword list provided by IntelliSense contains readonly, as it matches my target.
Currently, the provided keywords are abstract, class, delegate, enum, interface, partial, sealed, static, struct, and unsafe.
readonly as well as ref can be provided together with them, as they are modifier for struct.

@CyrusNajmabadi
Copy link
Member

@jcouv I'm a bit concerned that new language features keep getting shipped, while basic scenarios like intellisense aren't being checked for. Completion is definitely in the test matrix for new language features, so i think we should figure out why that's been missed numerous times so far.

@jcouv
Copy link
Member

jcouv commented Apr 16, 2018

@CyrusNajmabadi I agree. This should have been covered as part of the feature work.
I see that we tested some completion (#19216 section "Misc"), but this one was missed.

@jcouv jcouv removed the Need More Info The issue needs more information to proceed. label Apr 16, 2018
@jcouv jcouv added this to the 15.8 milestone Apr 16, 2018
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Apr 17, 2018
@jcouv jcouv assigned jcouv and unassigned VSadov Apr 17, 2018
@jcouv
Copy link
Member

jcouv commented May 2, 2018

Fixed checked in for 15.8.

@jcouv jcouv added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants