Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Run Code Analysis and Suppress Active Issues" & "Configure Code Analysis" Issues shows on CPS projects but does nothing #27002

Closed
davkean opened this issue May 21, 2018 · 3 comments
Closed

"Run Code Analysis and Suppress Active Issues" & "Configure Code Analysis" Issues shows on CPS projects but does nothing #27002

davkean opened this issue May 21, 2018 · 3 comments
Assignees
@mavasani
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
16.0

Comments

@davkean
Copy link
Member

davkean commented May 21, 2018 •
edited
Loading

Version Used:
15.8 Preview 3

We recently made a change that caused Project.Kind to return the legacy project system, this has caused "Run Code Analysis and Suppress Active Issues" and "Configure Code Analysis" to show up despite them not working.

Make note, "Run Code Analysis" does not show up, so it seems like these other two commands have different light up checks to it.

Steps to Reproduce:

  1. File -> New Console App (.NET Core)
  2. Right-click on project and point to Analyze

-or-

  1. Select project and choose Analyze

image

image
image
@davkean davkean mentioned this issue May 21, 2018
Closed
@davkean
Copy link
Member Author

davkean commented May 21, 2018

Make note you need to actually load StanPackage first by running one of the Analyze commands in menu bar.

@jinujoseph jinujoseph added this to the 15.8 milestone Jun 16, 2018
@sharwell sharwell added the Bug label Jun 16, 2018
@mavasani
Copy link
Contributor

Configure Code Analysis part ported to VSO bug 652026. I will soon send a Roslyn PR to fix the suppress active issues command.

mavasani added a commit to mavasani/roslyn that referenced this issue Jul 20, 2018
@mavasani
Fix "Run Code Analysis and Suppress Active Issues" command for CPS pr…
1dca287 
…ojects

Use IHierarchyItemToProjectIdMap service to compare project hierarchies.
Fixes dotnet#27002
@mavasani mavasani mentioned this issue Jul 20, 2018
Merged
@mavasani mavasani added the 4 - In Review A fix for the issue is submitted for review. label Jul 20, 2018
@mavasani
Copy link
Contributor

Note: This VSO PR renames and fixes the command to make it consistent for both CPS and non-CPS based projects, we don't run FxCop now as part of this command.

@jinujoseph jinujoseph modified the milestones: 15.8, 16.0 Jul 23, 2018
@jinujoseph jinujoseph added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
4 participants
@davkean @sharwell @mavasani @jinujoseph