Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Prefer braces' feature shoudl be called 'Require braces' #29621

Open
CyrusNajmabadi opened this issue Aug 31, 2018 · 1 comment
Open

'Prefer braces' feature shoudl be called 'Require braces' #29621

CyrusNajmabadi opened this issue Aug 31, 2018 · 1 comment
Labels
Area-IDE Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. Need Design Review The end user experience design needs to be reviewed and approved.
Projects
IDE: Design review
Milestone
Backlog

Comments

@CyrusNajmabadi
Copy link
Member

The name of the feature makes it feel like it's specifying a preference between always having braces, or never having them (if they can be removed). But that's not really what the feature is. The feature is about whether or not the braces are required. If 'yes', we tell the user there's a problem if they're absent. If 'no', we're just silent.

There is nothing that pushes the code to ever remove braces (which is a good thing IMO). So the name should be updated to not imply that it would.
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Aug 31, 2018
Open
@jinujoseph
Copy link
Contributor

related to #29606

@jinujoseph jinujoseph added the Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. label Sep 6, 2018
@jinujoseph jinujoseph added this to the Unknown milestone Sep 6, 2018
@jinujoseph jinujoseph added the Need Design Review The end user experience design needs to be reviewed and approved. label Sep 6, 2018
@jinujoseph jinujoseph modified the milestones: Unknown, 16.0 Sep 6, 2018
@sharwell sharwell added this to In Queue in IDE: Design review Sep 10, 2018
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Sep 17, 2018
Closed
@jinujoseph jinujoseph modified the milestones: 16.0, 16.1 Jan 16, 2019
@jinujoseph jinujoseph modified the milestones: 16.1, Backlog Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. Need Design Review The end user experience design needs to be reviewed and approved.
Projects
IDE: Design review
Status: In Queue
IDE: Design review
  
In Queue
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @CyrusNajmabadi @jinujoseph