-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApplyEditorConfigAndFixAllOccurrences and ApplyEditorConfigAndFormatDocument Failures in dev16.0.x #30015
Comments
This is a critical integration test. We need to see it passing in at least one of the debug or release queues or there is a likelihood we broke the feature. It looks like the feature is passing in the release queue. |
Ah, thanks @sharwell. @heejaechang do we know if anything changed in dev16.0.x recently that might have caused this? I will try to get a repro locally. |
can we get %temp%\servicehub\logs? our side didn't change but service hub and extension manager has changed I believe that our OOP is built on. but regardless, the logs in that directory will give us pretty clear idea what is going on. |
@heejaechang Can you see if the servicehub logs here help: https://ci.dot.net/job/dotnet_roslyn/job/dev16.0.x/job/windows_debug_vs-integration/18/artifact/Binaries/Temp/servicehub/logs/ |
@mavasani it has client (VS) side log saying something threw, but no log from server (OOP) side which tells me what has thrown. |
are we keeping all logs? or only some logs? if the exception is thrown before our code ran in OOP, then it will be only saved in servicehub side log, but not our side. but it will show up in VS side since that doesn't care what part has failed as long as servicehub side failed. |
@heejaechang I believe we only have client side logs, but probably someone from @dotnet/roslyn-infrastructure can confirm. |
By the way, I am unable to repro this failure locally, even when run in batch with other integration tests. |
Another failing editorconfig test: ApplyEditorConfigAndFormatDocument
|
@jinujoseph On the schedule, this is the most important test. It must be fixed/enabled/passing for preview 1. |
Note that the test passes consistently locally, even when executed multiple times in isolation or with other tests. We probably need to enable service hub logging on Jenkins to find what is causing the crash. |
@heejaechang , is it possible to add more logging to capture whats happening here. |
@jinujoseph I don't know much on our integration test env. where do I need to look to see how I can copy over logs to some place in jenkins? and where should I copy it over? |
@mavasani These tests cannot be skipped for release. Moving back to 16.0.P4. |
Closing as #33517 unskips these tests. If we start seeing flakiness, we can re-open this issue. |
Saw this again: Test Logs Error message:
Stack trace:
DotNet.log
|
These failures coincided with @jasonmalinowski's recent change to work around a platform bug. |
Thanks Sam. Opened #34288 to track the real issue. |
This test is consistently failing in the debug builds of dev16.0.x, starting with this build:
https://ci.dot.net/job/dotnet_roslyn/job/dev16.0.x/job/windows_debug_vs-integration/3/
The text was updated successfully, but these errors were encountered: