Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests do not cover async completion #33797

Closed
sharwell opened this issue Mar 1, 2019 · 0 comments
Closed

Integration tests do not cover async completion #33797

sharwell opened this issue Mar 1, 2019 · 0 comments
Assignees
@sharwell
Labels
Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info Integration-Test Test failures in roslyn-integration-CI Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
16.0

Comments

@sharwell
Copy link
Member

sharwell commented Mar 1, 2019

Async completion is completely disabled for integration testing, offering us no validation of the upcoming feature:

roslyn/src/VisualStudio/IntegrationTest/TestUtilities/VisualStudioInstanceFactory.cs

Lines 327 to 328 in 2773f5e

// Disable async completion for 16.0 Preview 3 testing
Process.Start(vsRegEditExeFile, $"set \"{installationPath}\" {Settings.Default.VsRootSuffix} HKCU \"ApplicationPrivateSettings\\WindowManagement\\Options\" UseAsyncCompletion string \"1*System.Int32*-1\"").WaitForExit();

@sharwell sharwell added Area-IDE Integration-Test Test failures in roslyn-integration-CI IDE-IntelliSense Completion, Signature Help, Quick Info labels Mar 1, 2019
@sharwell sharwell mentioned this issue Mar 1, 2019
Merged
@sharwell sharwell mentioned this issue Mar 2, 2019
Merged
@sharwell sharwell added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Mar 2, 2019
@sharwell sharwell self-assigned this Mar 2, 2019
@sharwell sharwell added this to the 16.0 milestone Mar 2, 2019
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Mar 3, 2019
@sharwell sharwell closed this as completed Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info Integration-Test Test failures in roslyn-integration-CI Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
1 participant
@sharwell