Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please reorder NullableAnnotation values to be in lattice order #33952

Closed
gafter opened this issue Mar 7, 2019 · 1 comment · Fixed by #34909
Closed

Please reorder NullableAnnotation values to be in lattice order #33952

gafter opened this issue Mar 7, 2019 · 1 comment · Fixed by #34909
Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
Compiler: Gafter Nullable Board
Milestone
16.1

Comments

@gafter
Copy link
Member

gafter commented Mar 7, 2019

The values of NullableAnnotation are not in the order that they appear in the lattice. Please reorder them so that they are in lattice order; that would permit a much simpler implementation of Meet and Join.
@gafter gafter added this to the 16.1 milestone Mar 7, 2019
@gafter gafter mentioned this issue Mar 7, 2019
Merged
@cston
Copy link
Member

cston commented Mar 7, 2019

The NullableAnnotation enum values are currently used as is in [NullableAttribute(values)] attributes in metadata, so changing the enum will be a breaking change unless we map to/from the current values when writing/reading metadata.

@gafter gafter added this to Nullable in Compiler: Gafter Mar 8, 2019
@jcouv jcouv added this to Misc in Nullable Board Mar 9, 2019
@gafter gafter moved this from Nullable to Active Work in Compiler: Gafter Apr 10, 2019
gafter added a commit to gafter/roslyn that referenced this issue Apr 10, 2019
@gafter
Remove the dependence between the order in NullableAnnotation and met…
597ac3a 
…adata attribute values

Fixes dotnet#33952
@gafter gafter mentioned this issue Apr 10, 2019
Merged
@gafter gafter moved this from Active Work to In Review in Compiler: Gafter Apr 10, 2019
gafter pushed a commit that referenced this issue Apr 15, 2019
Remove the dependence between the order in NullableAnnotation and met…
e922628 
…adata attribute values (#34909)

Fixes #33952
RikkiGibson pushed a commit to RikkiGibson/roslyn that referenced this issue Apr 25, 2019
@RikkiGibson
Remove the dependence between the order in NullableAnnotation and met…
be28124 
…adata attribute values (dotnet#34909)

Fixes dotnet#33952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
Nullable Board
Misc
Compiler: Gafter
In Review
Milestone
16.1
3 participants
@gafter @cston @jcouv