Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code handling different TextDocument kinds in the IDE layers #35863

Open
mavasani opened this issue May 21, 2019 · 1 comment
Open

Comments

@mavasani
Copy link
Member

mavasani commented May 21, 2019

We now have 3 distinct text document kinds: Document (regular source document), AdditionalDocument (additional files) and AnalyzerConfigDocument (editorconfig files). We have large number of places in the IDE layer where each client has to deal with all the 3 different document kinds, also leading to lot of code duplication. This issue tracks refactoring the code so that we have a central service/shim that handles all different document kinds and exposes APIs such that the client does not need to handle each document kind.

See following comments for some ideas on this work:

  1. 4c0459a#r284291020
  2. https://github.com/dotnet/roslyn/pull/35762/files#r286224367, https://github.com/dotnet/roslyn/pull/35762/files#r286224882
  3. https://github.com/dotnet/roslyn/pull/35762/files#r286232360
  4. https://github.com/dotnet/roslyn/pull/35762/files#r286227148
  5. https://github.com/dotnet/roslyn/pull/35762/files#r286228639
  6. https://github.com/dotnet/roslyn/pull/35762/files#r286235383
  7. https://github.com/dotnet/roslyn/pull/35762/files#r286236054
  8. https://github.com/dotnet/roslyn/pull/35762/files#r286239878
@mavasani
Copy link
Member Author

Tagging @jasonmalinowski @heejaechang @CyrusNajmabadi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants