Nullability rewriter is O(2^n) when visiting converted tuple literals #36880
Labels
Area-Compilers
Bug
Concept-Design Debt
Engineering Debt, Design Debt, or poor product code quality
New Language Feature - Nullable Reference Types
Nullable Reference Types
Milestone
The generated Nullability rewriter contains a method that begins
The bound trees in
node.Arguments
share part of the expression tree withnode.SourceTuple
. Consequently, they will be visited twice. When tuples are nested n deep, nodes at the leaves will be visited O(2n) times.We want to avoid repeated visits of a given node, so this needs to be revised.
/cc @chsienki
The text was updated successfully, but these errors were encountered: