Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a git worktree Microsoft.Build.Tasks.Git.targets fails to verify #37141

Closed
alrz opened this issue Jul 11, 2019 · 4 comments · Fixed by #37001
Closed

Using a git worktree Microsoft.Build.Tasks.Git.targets fails to verify #37141

alrz opened this issue Jul 11, 2019 · 4 comments · Fixed by #37001

Comments

@alrz
Copy link
Member

alrz commented Jul 11, 2019

Version Used: 2ee0e35

Steps to Reproduce:

  1. Run restore
  2. Run build
...
C:\Users\<username>\.nuget\packages\microsoft.build.tasks.git\1.0.0-beta2-19324-01\build\Microsoft.Build.Tasks.Git.targets(10,5): error : Error reading git repository information: Path specified in file 'C:\<root>\.git' is invalid. [C:\<root>\src\VisualStudio\Setup.Dependencies\Roslyn.VisualStudio.Setup.Dependencies.csproj]
    0 Warning(s)
    23 Error(s)

Note: this is ran from a git worktree

@alrz
Copy link
Member Author

alrz commented Jul 11, 2019

perhaps this doesn't belong to roslyn repo. I don't know where this should be filed.

@alrz
Copy link
Member Author

alrz commented Jul 11, 2019

After commenting Microsoft.Build.Tasks.Git.LocateRepository out, generated source link is empty is reported. could we just disable it on local builds?

@tmat
Copy link
Member

tmat commented Jul 11, 2019

I believe this has been fixed. We need to update to the new version of SourceLink.

@qlikTERror
Copy link

This is still a problem with Microsoft.SourceLink.GitHub 1.1.1 and Microsoft.Build.Tasks.Git 1.1.1 and using worktrees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants