Localized string key in generated .editorconfig

[20chan]

Version Used:

Visual Studio 2019 16.3.6, Korean, C#

Steps to Reproduce:

1. Set language to Korean
2. Generate .editorconfig from Tools->Options

Expected Behavior:

Only localized strings in comments.

Actual Behavior:

Key and value contains localized strings.

#### 명명 스타일 ####

# 명명 규칙

dotnet_naming_rule.interface_should_be_i로_시작.severity = suggestion
dotnet_naming_rule.interface_should_be_i로_시작.symbols = interface
dotnet_naming_rule.interface_should_be_i로_시작.style = i로_시작

full .editorconfig: gist

[20chan]

I found what was problem.

roslyn/src/Workspaces/Core/Portable/Options/EditorConfig/EditorConfigFileGenerator.cs

Lines 93 to 94 in a1533f0

	var namingStylePreferences = optionSet.GetOption(SimplificationOptions.NamingPreferences, language);
	var serializedNameMap = AssignNamesToNamingStyleElements(namingStylePreferences);

Here gets options by local language. And it's serializedNameMap was used into raw string.

roslyn/src/Workspaces/Core/Portable/Options/EditorConfig/EditorConfigFileGenerator.cs

Lines 123 to 125 in a1533f0

	editorconfig.AppendLine($"dotnet_naming_symbols.{serializedNameMap[symbolSpecification.ID]}.applicable_kinds = {symbolSpecification.ApplicableSymbolKindList.ToEditorConfigString()}");
	editorconfig.AppendLine($"dotnet_naming_symbols.{serializedNameMap[symbolSpecification.ID]}.applicable_accessibilities = {symbolSpecification.ApplicableAccessibilityList.ToEditorConfigString(language)}");
	editorconfig.AppendLine($"dotnet_naming_symbols.{serializedNameMap[symbolSpecification.ID]}.required_modifiers = {symbolSpecification.RequiredModifierList.ToEditorConfigString(language)}");

[20chan]

I submitted a PR here.

[sharwell]

The localized strings appearing in keys and values are taken from user-modifiable content in the UI. Even if we account for all the default cases, it will be impossible to account for cases where the user has modified options prior to generating the .editorconfig file.

[sharwell]

Here is the UI where names can be changed by users:

[20chan]

Right, it was because just default generated keys are in localized language and also sample identifiers are.
But it just makes me confused. I had no idea why it is also localized when I generated .editorconfig fire at first, I didn't change anything at all. Default-generated localized .editorconfig seems like rude for other global programmers.

All codes-stuffs are my mistakes, I closed my PR.
And topic of this issue should be changed or something else.

[sharwell]

@20chan This has been reported a few times now. I'm going to check with one of our localization team members and see if there is anything else we can do to improve the experience.