Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error list experience on closing documents #39902

Closed
mavasani opened this issue Nov 20, 2019 · 1 comment · Fixed by #39892
Closed

Error list experience on closing documents #39902

mavasani opened this issue Nov 20, 2019 · 1 comment · Fixed by #39892
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.

Comments

@mavasani
Copy link
Contributor

Follow-up issue to discuss #39892 (comment). That PR restores the prior error list behavior of removing closed file diagnostics from error list whenever a document is closed. This issue tracks discussing if we want to change that experience.
@mavasani mavasani added Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved. labels Nov 20, 2019
@mavasani mavasani mentioned this issue Nov 20, 2019
Merged
@dpoeschl
Copy link
Contributor

Design Meeting Notes

We would like to keep the new behavior (diagnostics not cleared when files closed) for C#/VB, but will help partner teams that want to restore the old behavior (diagnostics cleared when files are closed) for their languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Projects
IDE: Design review
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove diagnostics from error list on document close or reset for tha… mavasani/roslyn
2 participants
@dpoeschl @mavasani