Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Add File Banner refactoring to the new AbstractFileHeaderHelper analysis #42203

Open
sharwell opened this issue Mar 5, 2020 · 1 comment
Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Milestone

Comments

@sharwell
Copy link
Member

sharwell commented Mar 5, 2020

#41982 implements a new file header analysis helper AbstractFileHeaderHelper. The previous Add File Banner refactoring needs to be converted to this approach for consistency across multiple features.

  1. Convert the current tests for Add File Banner to the new test library (which offers stronger guarantees and can better detect changes in behavior)
  2. Convert Add File Banner to the new AbstractFileHeaderHelper, and address any changes in behavior
@sharwell sharwell added Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Mar 5, 2020
@CyrusNajmabadi
Copy link
Member

We also have a few things that check banners i believe. like sort-usings (which doesn't want to move banners around, even though they're leading trivia), and potentially move/extract-type.

But i believe all these go through the common helpers. so if you fix those up, we should be good.

Note: these common helpers are on ISyntaxFacts. I'm 100% fine if you want to break them into their own special Helper class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
None yet
Development

No branches or pull requests

3 participants