Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to Solution snapshot entities from GenerateTypeDialogViewModel #42929

Open
tmat opened this issue Mar 31, 2020 · 0 comments
Open

Remove references to Solution snapshot entities from GenerateTypeDialogViewModel #42929

tmat opened this issue Mar 31, 2020 · 0 comments
Labels
Area-IDE Concept-OOP Related to out-of-proc
Milestone
Backlog

Comments

@tmat
Copy link
Member

tmat commented Mar 31, 2020

Microsoft.VisualStudio.LanguageServices.Implementation.GenerateType.GenerateTypeDialogViewModel holds on Project and Document snapshots. These shouldn't be accessed from a view model.
@tmat tmat added Concept-OOP Related to out-of-proc Area-IDE labels Mar 31, 2020
@jinujoseph jinujoseph added this to the 16.7 milestone Apr 8, 2020
@jinujoseph jinujoseph modified the milestones: 16.7, 16.8 Jun 19, 2020
@jinujoseph jinujoseph modified the milestones: 16.8, 16.9 Sep 10, 2020
@jinujoseph jinujoseph modified the milestones: 16.9, Backlog Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-OOP Related to out-of-proc
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@tmat @jinujoseph