Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution explorer should be smarter about sorting file names. #52920

Open
CyrusNajmabadi opened this issue Apr 26, 2021 · 4 comments
Open

Solution explorer should be smarter about sorting file names. #52920

CyrusNajmabadi opened this issue Apr 26, 2021 · 4 comments

Comments

@CyrusNajmabadi
Copy link
Member

In cases like this:

image

The third item should actually be sorted first, as with normal .net naming here, it's considered the most important part. In other words, we shoudl think of file names as being broken into dotted pieces, where the extension is always last, and the pieces shoudl be compared. In this case, as the third item has no second piece, it comes before all the effectively nested items which do.

This should work regardless of how many layers of nesting there are.

I have no idea who owns this. It might be roslyn, it might be project system, it might be platform. But i'm opening here in case it is us.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 26, 2021
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski @davkean Do you know who this should route to?

@CyrusNajmabadi
Copy link
Member Author

Note: this sorting is what we do in navto:

image

Here, Roslyn owns the sorting, so we can properly order these as is desirable for .net code. It would be nice to be able to bring this to any list of files.

@davkean
Copy link
Member

davkean commented Apr 26, 2021

tag @lifengl. I've run into the same issue, what if we automatically nested these under the core file? Currently we just do alpha sorting, with zero smarts.

@lifengl
Copy link

lifengl commented Apr 27, 2021 via email

@jinujoseph jinujoseph added Concept-Continuous Improvement Area-External and removed untriaged Issues and PRs which have not yet been triaged by a lead Area-IDE labels Apr 28, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Apr 28, 2021
@jinujoseph jinujoseph self-assigned this Jul 27, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Dec 10, 2021
@jinujoseph jinujoseph modified the milestones: 17.1, 17.3 Apr 27, 2022
@arkalyanms arkalyanms modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants