Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense: put ref at the top when required. #54070

Open
Kuinox opened this issue Jun 14, 2021 · 5 comments
Open

Intellisense: put ref at the top when required. #54070

Kuinox opened this issue Jun 14, 2021 · 5 comments
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@Kuinox
Copy link
Contributor

Kuinox commented Jun 14, 2021

Brief description:
The caller must also prefix ref an argument that the callee prefixed with ref.
When you have such an argument, IntelliSense tries to autocomplete with a possible argument input, but the only valid word to write is ref, before the actual argument.

Languages applicable:
C#

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 14, 2021
@CyrusNajmabadi
Copy link
Member

This seems reasonable.

@sharwell
Copy link
Member

One other valid option at this location is an explicit parameter name (e.g. name:). Depending on the current context, the completion heuristics might identify that the name is required.

As an edge case, ref is optional for certain members defined in ComImport signatures (and for some items like Guid are frequently omitted).

Can you show more details about the items appearing in the completion list at this location?

@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 16, 2021
@sharwell sharwell added the Need More Info The issue needs more information to proceed. label Jun 16, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Jun 16, 2021
@Kuinox
Copy link
Contributor Author

Kuinox commented Jun 16, 2021

With IntelliCode:
image
Without IntelliCode:
image
When I type the first letter:
image

So I thought Intellisense did prioritize the arguments, But it looks like it start ranking the argument and ref higher when you start typing.

@ghost ghost added the fabric-bot-test Testing the impact of changes to the fabric bot label Aug 10, 2021
@ghost ghost closed this as completed Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Closing this issue as we've seen no reply to the request for more information. If you are able to get the requested information, please add it to the issue and we will retriage it.

@333fred
Copy link
Member

333fred commented Sep 15, 2021

@sharwell was this enough info, or do you still need more?

@333fred 333fred reopened this Sep 15, 2021
@ghost ghost added untriaged Issues and PRs which have not yet been triaged by a lead and removed Need More Info The issue needs more information to proceed. labels Sep 15, 2021
@jinujoseph jinujoseph added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed untriaged Issues and PRs which have not yet been triaged by a lead fabric-bot-test Testing the impact of changes to the fabric bot labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

No branches or pull requests

5 participants