Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnC - Attribute updates on parameters don't get emitted #54777

Closed
davidwengier opened this issue Jul 12, 2021 · 0 comments · Fixed by #54835
Closed

EnC - Attribute updates on parameters don't get emitted #54777

davidwengier opened this issue Jul 12, 2021 · 0 comments · Fixed by #54835
Assignees
@davidwengier
Labels
Area-IDE Concept-Continuous Improvement Interactive-EnC
Projects
HotReload
Milestone
17.0

Comments

@davidwengier
Copy link
Contributor

Analysis of attributes on parameters was added in #49012 but in the course of #52563 (and other work) it was discovered that parameters don't get emitted for method updates, hence the attributes for them also don't get emitted.

Logging this as a separate issue because it requires some work from #52563 and some from #54430 but doesn't need to wait for either.
@davidwengier davidwengier self-assigned this Jul 12, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 12, 2021
@davidwengier davidwengier mentioned this issue Jul 12, 2021
Open
6 tasks
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 14, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Jul 14, 2021
@davidwengier davidwengier mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Area-IDE Concept-Continuous Improvement Interactive-EnC
Projects
HotReload
Awaiting triage
Milestone
17.0
Development

Successfully merging a pull request may close this issue.

Emit attribute changes for parameters davidwengier/roslyn
3 participants
@jaredpar @davidwengier @jinujoseph