Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync namespaces for .NET Framework #61421

Open
vsfeedback opened this issue May 19, 2022 · 6 comments
Open

Sync namespaces for .NET Framework #61421

vsfeedback opened this issue May 19, 2022 · 6 comments
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


Sync namespaces is only available for .NET Core projects. Please add this functionality to .NET Framework projects, too.


Original Comments

Feedback Bot on 4/26/2022, 00:08 AM:

(private comment, text removed)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 19, 2022
@sharwell
Copy link
Member

💡 This feature does not disable itself based on target framework, but it's only implemented for CPS projects. Projects that still use the legacy project system don't implement the capability support we rely on here:

// Is a project node. Are we C# project node?
visible = projectHierarchy.IsCapabilityMatch(".NET & CSharp");

@sharwell sharwell added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 19, 2022
@sharwell sharwell added this to the Backlog milestone May 19, 2022
@CyrusNajmabadi
Copy link
Member

@sharwell should we move this then to the legacy project system owners so they can track these requests?

@sharwell
Copy link
Member

@CyrusNajmabadi I don't believe there's any expectation of the legacy project system supporting these features. There are other ways to detect a legacy .NET/C# project, and we can rely on those at the above Roslyn code location.

@janseris
Copy link

janseris commented May 24, 2022

.NET Framework projects really need this feature. And they need it especially because of the fact that they are the usually the legacy code.
This means that there is monolithic architecture etc. If someone is to fix/refactor/edit/extend an old project, this is one of the essential functionalities together with rich code navigation (number of references etc.).

@sharwell
Copy link
Member

.NET Framework projects really need this feature.

.NET Framework projects already have this feature, as long as they are using the new SDK-style projects. The feature is only missing from projects that use the old project system.

With that said, the issue is now marked as help wanted. We would welcome a pull request that updates the line I mentioned to account for the possibility that a project may be using the old project system, provided the feature still works in that case.

@Seabizkit
Copy link

please add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

No branches or pull requests

5 participants