Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File types should work with EnC #61999

Closed
2 tasks
RikkiGibson opened this issue Jun 17, 2022 · 2 comments
Closed
2 tasks

File types should work with EnC #61999

RikkiGibson opened this issue Jun 17, 2022 · 2 comments
Assignees
Labels
Area-Compilers Area-Interactive Interactive-EnC untriaged Issues and PRs which have not yet been triaged by a lead
Milestone

Comments

@RikkiGibson
Copy link
Contributor

Related to #60819

  • SymbolKey needs to be updated to encode and resolve file types from source and metadata.
  • EnC needs to be able to relate file types from one generation to the next, even if the order of files changes. (No need to be resilient to the file name changing--that can be treated as a delete+insert rather than a modification.)
@RikkiGibson RikkiGibson self-assigned this Jun 17, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 17, 2022
@tmat
Copy link
Member

tmat commented Jun 20, 2022

EnC needs to be able to relate file types from one generation to the next, even if the order of files changes

I don't think that's the best approach here. It'd be much simpler if the compiler did not rely on order of syntax trees in the compilation.

@RikkiGibson
Copy link
Contributor Author

We addressed this in 17.4, but further issues were observed which we think we can address at a later date. Tracked in #64098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Area-Interactive Interactive-EnC untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

No branches or pull requests

3 participants