Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig UI 'place open brace *' options are not working #62942

Open
Youssef1313 opened this issue Jul 26, 2022 · 2 comments
Open

EditorConfig UI 'place open brace *' options are not working #62942

Youssef1313 opened this issue Jul 26, 2022 · 2 comments

Comments

@Youssef1313
Copy link
Member

  1. Create a new project
  2. Add EditorConfig file
  3. Open it using EditorConfig UI
  4. In Whitespace tab, modify any "place open brace on ..." option. Nothing gets saved.

Other options are working properly, so I think this is not duplicate of #54556

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 26, 2022
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jul 26, 2022

This applies to insert spaces within parentheses of options as well.

@Youssef1313
Copy link
Member Author

What is special about the options that don't work is they use this overload of editorconfig location:

public EditorConfigStorageLocation(string keyName, Func<string, Optional<T>> parseValue, Func<OptionSet, string> getEditorConfigStringForValue)
: this(keyName, parseValue, (value, optionSet) => getEditorConfigStringForValue(optionSet))
{
if (getEditorConfigStringForValue == null)
{
throw new ArgumentNullException(nameof(getEditorConfigStringForValue));
}
}

@vatsalyaagrawal vatsalyaagrawal added Bug Feature - Editor Config UI and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 27, 2022
@vatsalyaagrawal vatsalyaagrawal added this to the 17.4 milestone Jul 27, 2022
@vatsalyaagrawal vatsalyaagrawal added the IDE-CodeStyle Built-in analyzers, fixes, and refactorings label Jul 27, 2022
@arkalyanms arkalyanms modified the milestones: 17.4, 17.6 P3 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants