Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksum algorithm set by GeneratorContexts.AddSource should be overridden by /checksumalgorithm switch #63039

Open
tmat opened this issue Jul 29, 2022 · 2 comments
Open

Checksum algorithm set by GeneratorContexts.AddSource should be overridden by /checksumalgorithm switch #63039

tmat opened this issue Jul 29, 2022 · 2 comments
Assignees
@chsienki
Labels
Area-Compilers Bug New Feature - Source Generators Source Generators
Milestone
Backlog

Comments

@tmat
Copy link
Member

tmat commented Jul 29, 2022 •
edited

Source generators can add source via GeneratorContexts.AddSource that does not match the checksum algorithm set by the project (command line switch /checksumalgorithm).

This is an issue since the project might require stronger checksum algorithm than the referenced generators use.

See #63038
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 29, 2022
@tmat
Copy link
Member Author

tmat commented Jul 29, 2022

@chsienki

@tmat tmat mentioned this issue Jul 29, 2022
Merged
@chsienki chsienki self-assigned this Jul 29, 2022
@jcouv jcouv added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 29, 2022
@jcouv jcouv added this to the 17.4 milestone Jul 29, 2022
@jaredpar jaredpar modified the milestones: 17.4, C# 12.0 Aug 16, 2022
@jaredpar jaredpar modified the milestones: C# 12.0, Backlog Sep 12, 2023
@jasonmalinowski jasonmalinowski mentioned this issue Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chsienki chsienki

Labels
Area-Compilers Bug New Feature - Source Generators Source Generators
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@tmat @jaredpar @jcouv @chsienki