-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update License for Roslyn compilers script GenerateSdkPackages to MIT #63257
Comments
Is |
I'll leave someone else to comment on whether it's needed, but I'm 99% sure the license is accurate. Certainly it shouldn't be MIT. |
This is correct. To the best of my recollection this is how we used to build SDK packages for inclusion in Visual Studio. Those do require the standard VS redist license which is used here.
I think this can be deleted. It's not used anymore. At least I'm going to send a PR to delete this and see if anyone screams. |
This does not appear to be used anymore in our builds and is making license scanning difficult. closes dotnet#63257
Deleting the GenerateSdkPackages if they are not used will resolve the licensing issue for us. |
This does not appear to be used anymore in our builds and is making license scanning difficult. closes #63257
Version Used:
.NET7 main branch
Steps to Reproduce:
1.See https://github.com/dotnet/roslyn/blob/main/scripts/GenerateSdkPackages/base.nuspec#L9 -- this has the reference to http://go.microsoft.com/fwlink/?LinkID=614949 which points to the MICROSOFT VISUAL STUDIO 2015 SOFTWARE DEVELOPMENT KIT License
(A sharplab repro is ideal for compiler/language issues whenever possible)
Expected Behavior:
This should point to the MIT License
Actual Behavior:
Points to https://visualstudio.microsoft.com/license-terms/mt171586/ which has the MICROSOFT VISUAL STUDIO 2015 SOFTWARE DEVELOPMENT KIT License.
The text was updated successfully, but these errors were encountered: