Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License for Roslyn compilers script GenerateSdkPackages to MIT #63257

Closed
janani66 opened this issue Aug 7, 2022 · 6 comments · Fixed by #63314
Closed

Update License for Roslyn compilers script GenerateSdkPackages to MIT #63257

janani66 opened this issue Aug 7, 2022 · 6 comments · Fixed by #63314

Comments

@janani66
Copy link

janani66 commented Aug 7, 2022

Version Used:
.NET7 main branch

Steps to Reproduce:

1.See https://github.com/dotnet/roslyn/blob/main/scripts/GenerateSdkPackages/base.nuspec#L9 -- this has the reference to http://go.microsoft.com/fwlink/?LinkID=614949 which points to the MICROSOFT VISUAL STUDIO 2015 SOFTWARE DEVELOPMENT KIT License

(A sharplab repro is ideal for compiler/language issues whenever possible)

Expected Behavior:
This should point to the MIT License

Actual Behavior:
Points to https://visualstudio.microsoft.com/license-terms/mt171586/ which has the MICROSOFT VISUAL STUDIO 2015 SOFTWARE DEVELOPMENT KIT License.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 7, 2022
@Youssef1313
Copy link
Member

Is GenerateSdkPackages actually used? Maybe it could be deleted entirely.

@davidwengier
Copy link
Contributor

I'll leave someone else to comment on whether it's needed, but I'm 99% sure the license is accurate. Certainly it shouldn't be MIT.

@omajid
Copy link
Member

omajid commented Aug 8, 2022

cc @crummel @lbussell @MichaelSimons

@vatsalyaagrawal vatsalyaagrawal added Investigation Required and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 9, 2022
@vatsalyaagrawal vatsalyaagrawal added this to the 17.4 milestone Aug 9, 2022
@leecow
Copy link
Member

leecow commented Aug 10, 2022

@jaredpar - this license is popping up in IBMs open source license scans. Can you help determine if it's correct?

Seems like the contents of /scripts isn't particularly interesting from a downstream source-build perspective. @crummel, do you know what RH does with this?

@jaredpar
Copy link
Member

I'll leave someone else to comment on whether it's needed, but I'm 99% sure the license is accurate. Certainly it shouldn't be MIT.

This is correct. To the best of my recollection this is how we used to build SDK packages for inclusion in Visual Studio. Those do require the standard VS redist license which is used here.

Is GenerateSdkPackages actually used? Maybe it could be deleted entirely.

I think this can be deleted. It's not used anymore. At least I'm going to send a PR to delete this and see if anyone screams.

jaredpar added a commit to jaredpar/roslyn that referenced this issue Aug 10, 2022
This does not appear to be used anymore in our builds and is making
license scanning difficult.

closes dotnet#63257
@janani66
Copy link
Author

Deleting the GenerateSdkPackages if they are not used will resolve the licensing issue for us.

jaredpar added a commit that referenced this issue Aug 15, 2022
This does not appear to be used anymore in our builds and is making
license scanning difficult.

closes #63257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants