Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Request: TypeSymbolExtensions #64

Closed
OmerRaviv opened this issue Jan 24, 2015 · 6 comments
Closed

API Request: TypeSymbolExtensions #64

OmerRaviv opened this issue Jan 24, 2015 · 6 comments
Assignees
Labels
Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Milestone

Comments

@OmerRaviv
Copy link
Contributor

Forking this feature request from #16

Original post: #16 (comment) by @MrJul

Pertinent APIs: http://source.roslyn.codeplex.com/#Microsoft.CodeAnalysis.CSharp/Symbols/TypeSymbolExtensions.cs,8f632696b9da5eba

In my team, I've seen different developers copy-paste portions of ITypeSymbolExtensions into our own project (e.g. IsNullableType, GetNullableUnderlyingType , GetBaseTypes ), which is a shame - these methods are a convenience I'm sure many other people will find useful as well.

@AdamSpeight2008
Copy link
Contributor

I could add them to RoslynExts, but it requires other internal class. @OmerRaviv these extension are not on ITypeSymbol but TypeSymbol

@theoy theoy added this to the Unknown milestone Jan 25, 2015
@theoy theoy added Concept-API This issue involves adding, removing, clarification, or modification of an API. Area-Compilers Feature Request labels Jan 25, 2015
@dpoeschl
Copy link
Contributor

Stackoverflow user "Mac" might want to use methods from a similar API, INamedTypeSymbolExtensions. http://stackoverflow.com/questions/28234052/finding-all-class-declarations-than-inherit-from-another-with-roslyn

@AnthonyDGreen Should this be a separate issue, or will we be evaluating a larger set of *Extensions classes as part of this API review?

@wwwlicious
Copy link

Thanks David, I've updated the post with the solution I hacked out, not sure if it is using bad practices though so if there is a ready made internal api for this it would be useful.

@OmerRaviv OmerRaviv changed the title API Request: ITypeSymbolExtensions API Request: TypeSymbolExtensions Feb 9, 2015
@wwwlicious
Copy link

any progress on this?

@pakdev
Copy link

pakdev commented Feb 3, 2017

Apparently Microsoft's other project (Roslyn Analyzers) also duplicates some of these extensions.

@jcouv jcouv modified the milestones: 15.later, Unknown Aug 2, 2017
@jaredpar jaredpar modified the milestones: 15.6, Unknown Nov 28, 2017
@CyrusNajmabadi
Copy link
Member

A request for this should go through our "api proposal" path. Note that these APIs are unlikely to be exposed as they are really 'feature-level' apis that encode feature semantics and change as necessary. As a public API we would be unable to do that as it would likely break people (or every change would need some way to make it opt-in only, which would greatly increase complexity).

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Projects
None yet
Development

No branches or pull requests

10 participants