Change contents of the TestSetup project #11037
Conversation
|
Review: @dotnet/roslyn-ide, @dotnet/roslyn-infrastructure |
| @@ -17,7 +17,6 @@ | |||
| <Assets> | |||
| <Asset Type="Microsoft.VisualStudio.MefComponent" Path="Roslyn.Hosting.Diagnostics.dll" /> | |||
| <Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%|" /> | |||
| <Asset Type="Microsoft.VisualStudio.VsPackage" Path="BindingPath.pkgdef" /> | |||
There was a problem hiding this comment.
This wasn't actually working since the file wasn't included in the VSIX. ProvideCodeBase is both more stable and more precise, so we'll use that instead.
|
@dotnet-bot, test vsi please. Also, retest this please since #11040 has been merged which fixed the other failures. |
|
@dotnet-bot, retest vsi please. There's been lots of churn in the last day. |
|
@dotnet-bot, retest vsi please. We've got some new diagnostics now to figure out failures. |
|
And we've fixed more issues with the machines, so @dotnet-bot, retest this please and retest vsi please. |
|
@dotnet-bot, test prtest/win/vsi/p0 please, test prtest/win/vsi/p1 please, test prtest/win/vsi/p2 please, test prtest/win/vsi/p3 please. |
|
test vsi0 please |
|
New tests responding to the phrase. Yay. |
Since this file wasn't being included in the VSIX, it was having no effect. We're better off using CodeBase attributes anyways which apply earlier in the assembly resolution process.
This is correctly bundled along with the language services VSIX, which is the place it should ship with. We already take a VSIX dependency upon that VSIX.
This is a DLL that doesn't ship and isn't used for anything other than pkgdef generation.
|
@dotnet-bot, retest roslyn_prtest_win_vsi0 please. (Investigating locally.) |
jasonmalinowski
force-pushed
the
change-contents-of-testsetup
branch
from
cc24f60
to
b562b2e
Compare
|
@dotnet-bot, test vsi please. |
|
Looks Correct To Me. |
|
👍 |
|
👍 |
The main goal here is to add an explicit CodeBase for Roslyn.Hosting.Diagnostics.dll which I do in fb4ccbc. The other changes generally clean things up, and reduce the package size from a few megabytes to a few kilobytes.