Language flag to only change diagnostics in syntax tree #11041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler for review. Thanks |
|
@VSadov @dotnet/roslyn-compiler for review, please. |
| </data> | ||
| <data name="String1" xml:space="preserve"> | ||
| <value /> | ||
| </data> |
There was a problem hiding this comment.
Is this addition intentional?
|
LGTM. There are a lot of test changes, I only glanced over them. |
| // (7,18): error CS1002: ; expected | ||
| // (a, b) => | ||
| Diagnostic(ErrorCode.ERR_SemicolonExpected, "").WithLocation(7, 18) | ||
| ); |
There was a problem hiding this comment.
This test is the only one that troubled me, as it used to pass parsing (it would have failed later).
There was a problem hiding this comment.
This is evidence that we need to really bang on the parser in situations that involve mixing lambdas, casts, tuple types, tuple expressions, etc.
In reply to: 62090097 [](ancestors = 62090097)
|
👍 |
|
@dotnet-bot test prtest/win/dbg/unit32 please |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing now goes down the same paths with or without feature flags, but it adds diagnostics when a feature is not enabled.
Note this affected some scenarios with illegal C# 6 code, which is now still illegal but different errors.
There is even one scenario where the parsing used to be legal, but is now a parsing error (
ParserErrorMessageTests.csbelow, which I discussed with Vlad).Fixes #10794 too (CompilerTrait).