Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automation to fetch #11052

Merged
merged 3 commits into from
May 4, 2016
Merged

Conversation

basoundr
Copy link
Contributor

@basoundr basoundr commented May 4, 2016

There are 2 changes here

  1. Move some of the helpers from test_util to tools_util since the helpers are not depended on the helper binary and can work without any dependencies
  2. Introduce TriggerAutomation.bat, which triggers the automation process.

The reason we need a bat file to trigger this and not a csx or a new csx is because running the csx requires the helper binary. Hence we need to run the csx files from the binaries folder but we cannot have binaries in place if we dont fetch them in the first place. This is a cyclic problem that has to be broken with the help of one initial Trigger Batch file

Tagging @KevinH-MS @rchande @TyOverby for review

There are 2 changes here
1. Move some of the helpers from test_util to tools_util since the helpers are not depended on the helper binary and can work without any dependencies
2. Introduce TriggerAutomation.bat, which triggers the automation process.

The reason we need a bat file to trigger this and not a csx or a new csx is because running the csx requires the helper binary. Hence we need to run the csx files from the binaries folder but we cannot have binaries in place if we dont fetch them in the first place. This is a cyclic problem that has to be broken with the help of one initial Trigger Batch file
@@ -16,7 +15,7 @@ var destinationFolder = Args.Count() == 2 ? Args[1] : @"C:\Roslyn\Binaries\Relea
var sourceFolder = $@"\\cpvsbuild\drops\Roslyn\Roslyn-{branch}-Signed-Release";

string latestBuild = null;
foreach (var folder in Directory.GetFiles(sourceFolder, "????????.?").Reverse())
foreach (var folder in Directory.GetDirectories(sourceFolder, "????????.?").Reverse())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider ????????.*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will modify in the next coming PRs

@KevinH-MS
Copy link
Contributor

👍

1 similar comment
@rchande
Copy link
Contributor

rchande commented May 4, 2016

👍

@basoundr basoundr merged commit 1fbca1c into dotnet:master May 4, 2016
@basoundr basoundr deleted the FixAutomationToFetch branch May 4, 2016 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants