Fix edge cases typing Enter before /**/ comments. #11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davkean Jenkins git failed to checkout? |
|
@mattwar @dotnet/roslyn-infrastructure |
|
We've had this happen once or twice more recently. I thought I had broken Jenkins for my own PR...clearly not. |
|
@dotnet/roslyn-ide for the review of the code itself. |
davkean
added
the
Community
|
retest this please |
|
LGTM 👍 |
|
👍 |
|
Any extra tests need to run? |
|
@DiryBoy Sorry - looks like we missed this one. Thanks for getting on these so quickly! |
|
@davkean You always respond in seconds. It's like late at night there? |
|
@DiryBoy Not too late, just before midnight. Github being external, means that I'm always on if I'm awake. :) |
|
@davkean Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11056
Fixes #11057