Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nameof() instead of string literals in ArgumentExceptions #11074

Merged
merged 1 commit into from
May 5, 2016
Merged

Use nameof() instead of string literals in ArgumentExceptions #11074

merged 1 commit into from
May 5, 2016

Conversation

bkoelman
Copy link
Contributor

@bkoelman bkoelman commented May 4, 2016

No description provided.

@Pilchie
Copy link
Member

Pilchie commented May 5, 2016

Tag @dotnet/roslyn-ide for review. @dotnet/roslyn-infrastructure do you know what's up with the Jenkins failures?

@jasonmalinowski
Copy link
Member

Yes, Jenkins had a bad change applied. Email discusses more internally. @dotnet-bot, retest this please.

@davkean davkean added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 5, 2016
@davkean
Copy link
Member

davkean commented May 5, 2016

👍

1 similar comment
@DustinCampbell
Copy link
Member

👍

@davkean
Copy link
Member

davkean commented May 5, 2016

Thanks for the contribution! Merging this in.

@davkean davkean merged commit 2f7f0d3 into dotnet:master May 5, 2016
@bkoelman bkoelman deleted the use-nameof branch May 12, 2016 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bkoelman @Pilchie @jasonmalinowski @davkean @DustinCampbell @dnfclas