Hide replace/original functionality behind a feature flag. #11157
Conversation
Since "original" is by itself contextual on the presence of "replace", only "replace" actually needs to be keyed off a flag.
|
note that, similarly to analyzers, invoking of actual generators is not conditional on language version/features. |
| @@ -14,6 +14,16 @@ namespace Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols | |||
| { | |||
| public class ReplaceOriginalTests : CSharpTestBase | |||
There was a problem hiding this comment.
Consider marking tests with the feature attribute.
There was a problem hiding this comment.
@AlekseyTs agree. This is now a pre-req before merging to future so let's do this now.
|
LGTM |
|
LGTM modulo attribute comment. |
| private static CSharpCompilation CreateCompilationWithMscorlib(string text, CSharpCompilationOptions options) | ||
| { | ||
| return CreateCompilationWithMscorlib(text, options: options, parseOptions: TestOptions.Regular.WithReplaceFeature()); | ||
| } |
There was a problem hiding this comment.
Consider using options = null and removing the other overload.
There was a problem hiding this comment.
done in a new change. Thanks
|
LGTM |
|
Agree with feature attribute comment. |
Since "original" is by itself contextual on the presence of "replace", only "replace" actually needs to be keyed off a flag.