Moved ISolutionCrawlerService down to workspace layer and made misc to use common default diagnostic analyzer service #11158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
changed the title
| @@ -43,7 +43,7 @@ public void TestPreviewCreationDefault() | |||
| [Fact, Trait(Traits.Editor, Traits.Editors.Preview)] | |||
| public void TestPreviewCreationWithExplicitHostServices() | |||
| { | |||
| var assembly = typeof(ISolutionCrawlerRegistrationService).Assembly; | |||
| var assembly = typeof(ISolutionCrawlerService).Assembly; | |||
There was a problem hiding this comment.
ISolutionCrawlerRegisterationService moved down to workspace layer
|
test vsi please |
|
ping? |
| @@ -8,7 +8,9 @@ | |||
|
|
|||
| namespace Microsoft.VisualStudio.LanguageServices.Implementation.CompilationErrorTelemetry | |||
| { | |||
| [ExportIncrementalAnalyzerProvider(WorkspaceKind.Host), Shared] | |||
| // Disabled compilation error telemetry per discussion with .net team. | |||
| // tracking bug - https://github.com/dotnet/roslyn/issues/11133 | |||
There was a problem hiding this comment.
Can you give some more context on this?
|
Change looks good to me - I'd still like to understand what exact API is being proposed for making public. |
|
this doesn't have anything public. more like moving code around so that
I will send out another PR which contains only APIs that are proposed for public API. |
|
@mavasani so are you okay checking this in? |
|
Yes, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
everything except making default diagnostic service public is done here.
this is done so that we can provide a way for users to turn on compiler diagnostics on an editor with custom text view.