Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed code hooking up the option for /**/ comments #11269

Merged
merged 2 commits into from
May 13, 2016

Conversation

pawchen
Copy link
Contributor

@pawchen pawchen commented May 12, 2016

Fixes #11264. Plus a property in the AutomationObject, don't know where it will be used though.

I can not find existing tests for persisting individual options. So I'm not sure how to properly prevent this from happening again.

@jasonmalinowski
Copy link
Member

👍. The AutomationObject is what is used to save/restore the settings from .settings files.

@jasonmalinowski
Copy link
Member

@dotnet/roslyn-ide for the review, and @dotnet-bot, test vsi please.

@Pilchie
Copy link
Member

Pilchie commented May 13, 2016

👍 from me.

@Pilchie Pilchie merged commit 56eb18a into dotnet:master May 13, 2016
@Pilchie
Copy link
Member

Pilchie commented May 13, 2016

Thanks again @DiryBoy!

@pawchen pawchen deleted the option branch May 13, 2016 02:44
@DustinCampbell
Copy link
Member

Great! thank you!

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants