Don't bundle binaries in VisualStudioSetup.Next #11337
Conversation
|
Tag @dotnet/roslyn-infrastructure @tannergooding @jasonmalinowski Hopefully this will fix signed builds. |
| @@ -21,6 +21,7 @@ | |||
| <ImportVSSDKTargets>true</ImportVSSDKTargets> | |||
| <TargetFrameworkVersion>v4.6</TargetFrameworkVersion> | |||
| <CopyNuGetImplementations>true</CopyNuGetImplementations> | |||
| <DeployExtension Condition="'$(VisualStudioVersion)' == '14.0'">false</DeployExtension> | |||
There was a problem hiding this comment.
Nit: more resilient to use this version:
<DeployExtension Condition="'$(VisualStudioVersion)' == '15.0'">true</DeployExtension>Accounts for the case where VisualStudioVersion is undefined.
There was a problem hiding this comment.
We rely on VisualStudioVersion everywhere.
There was a problem hiding this comment.
Okay. I've gotten bitten by that in the past. Maybe it's an issue that's since been fixed.
There was a problem hiding this comment.
We define it in our core targets if it's unset, because we do rely on it everywhere.
There was a problem hiding this comment.
So it is a real problem, we just work around it? Great, not crazy (abotu that)
|
👍 |
1 similar comment
|
👍 |
|
Test vsi please |
Also, don't install it as part of build on Dev14.
Pilchie
force-pushed
the
ExtensionBundling
branch
from
54fc185
to
e5e92ef
Compare
|
Pushed new version of the branch so that this commit can go into both |
Also, don't install it as part of build on Dev14.