Allow async methods to return Task-like types #12518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljw1004, @dotnet/roslyn-compiler please review |
| case SymbolKind.ArrayType: | ||
| // PROTOTYPE(tasklike): Use VisitType or similar to cover all cases. | ||
| break; | ||
| { |
There was a problem hiding this comment.
I think arrays, tuples and generics are the only constructed types. We'll have to make sure it works with Tuples. Whose job is that? (other than that, LGTM)
|
Starting review. Sorry for the delay. |
| @@ -660,6 +660,7 @@ Microsoft.CodeAnalysis.Semantics.UnaryOperationKind.UnsignedPrefixIncrement = 77 | |||
| abstract Microsoft.CodeAnalysis.Diagnostics.OperationBlockStartAnalysisContext.RegisterOperationAction(System.Action<Microsoft.CodeAnalysis.Diagnostics.OperationAnalysisContext> action, System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.OperationKind> operationKinds) -> void | |||
| abstract Microsoft.CodeAnalysis.Diagnostics.OperationBlockStartAnalysisContext.RegisterOperationBlockEndAction(System.Action<Microsoft.CodeAnalysis.Diagnostics.OperationBlockAnalysisContext> action) -> void | |||
| abstract Microsoft.CodeAnalysis.SemanticModel.GetOperationCore(Microsoft.CodeAnalysis.SyntaxNode node, System.Threading.CancellationToken cancellationToken) -> Microsoft.CodeAnalysis.IOperation | |||
| const Microsoft.CodeAnalysis.WellKnownMemberNames.CreateAsyncMethodBuilder = "CreateAsyncMethodBuilder" -> string | |||
There was a problem hiding this comment.
This is the only const I can find in shipped.txt and unshipped.txt. Do we really need it public?
Nevermind, I see similar public constants in src\Compilers\Core\Portable\PublicAPI.Shipped.txt ;-)
|
LGTM |
cston
force-pushed
the
tasklike-p4
branch
2 times, most recently
from
12b5d0b
to
6c5c666
Compare
|
@jcouv, @ljw1004 thanks for reviewing. The latest commit should cover all feedback. @dotnet/roslyn-compiler please provide an additional review. @MattGertz for approval. |
|
Approved pending the usual signoffs. |
[Based on features/async-return with tests ported from that branch.]
|
Nice!!! 🎈 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow async methods to return types other than
void,Task, orTask<T>. Specifically allowTask-like types (andAsyncMethodBuildertypes) if the types contain the expected set of members.[Based on Lucian's prototype from
features/async-return.]Ported PR from
master: #12434. I will follow up on existing feedback from that PR, making changes here.