readonly ref local functions, error tolerance in parsing, more tests.
#17223
Conversation
Correclty handle local functions.
|
@dotnet/roslyn-compiler - FYI |
| Assert.NotNull(p.GetMethod); | ||
| Assert.False(p.GetMethod.IsImplicitlyDeclared); | ||
| Assert.True(p.IsExpressionBodied); | ||
| Assert.Equal(RefKind.Ref, p.GetMethod.RefKind); |
There was a problem hiding this comment.
Assert.Equal(RefKind.Ref, p.GetMethod.RefKind); [](start = 12, length = 47)
Is this correct? Should this be a "readonly ref"? #Closed
There was a problem hiding this comment.
This is correct for now. Binding is NYI and falls back on regular ref returns.
The test will conveniently fail when binding is implemented.
In reply to: 102295224 [](ancestors = 102295224)
There was a problem hiding this comment.
Then we should probably have a "Prototype" comment here (similar to ReadonlyRefReturningDelegate test added in this PR), so that we could ensure the test is adjusted at the end.
In reply to: 102322176 [](ancestors = 102322176,102295224)
| { | ||
| Error(diagnostics, ErrorCode.ERR_BadAsyncLocalType, declarator); | ||
| var refKeyword = typeSyntax.GetFirstToken(); | ||
| diagnostics.Add(ErrorCode.ERR_UnexpectedToken, refKeyword.GetLocation(), refKeyword.ToString()); |
There was a problem hiding this comment.
diagnostics.Add(ErrorCode.ERR_UnexpectedToken, refKeyword.GetLocation(), refKeyword.ToString()); [](start = 16, length = 96)
Could you please point to the test that goes through this code path? #Closed
There was a problem hiding this comment.
ReadonlyRefReturn_UnexpectedBindTime
We allow readonly ref locals at parse time for error recovery purposes, but will fail at bind time.
This is the same strategy as used for regular ref. We parse it as RefType in more places than where it is semantically allowed, but fail to bind with this error.
Also there is a possibility we would allow readonly ref locals. That is another reason for having the check at bind time.
In reply to: 102299405 [](ancestors = 102299405)
There was a problem hiding this comment.
I am probably missing something, but I don't see this error reported for a local declaration in that test.
In reply to: 102323203 [](ancestors = 102323203,102299405)
There was a problem hiding this comment.
Because binding is NYI and we fallback on "Ref", which is valid.
I will add PROTOTYPE note
In reply to: 102336648 [](ancestors = 102336648,102323203,102299405)
|
Consider adding tests for deconstruction declarations, out var declarations and declaration patterns. #Closed |
VSadov
changed the title
readonly ref returnsreadonly ref local functions, error tolerance in parsing, more tests.
Correclty handle local functions.