Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test explorer by removing the xUnit Visual Studio runner #20569

Merged
merged 1 commit into from Jul 3, 2017

Conversation

sharwell
Copy link
Member

Works around major performance problems with Test Explorer in the current preview release (already fixed for an upcoming release but not yet available).

@sharwell sharwell requested review from jaredpar and a team June 30, 2017 16:14
@sharwell sharwell added the Contributor Pain The issue impedes progress for project collaborators. label Jun 30, 2017
@Pilchie
Copy link
Member

Pilchie commented Jun 30, 2017

Tag @KevinH-MS I believe this explicitly contradicts the work to get Live Unit Testing working with Roslyn.sln 😦

@sharwell
Copy link
Member Author

@Pilchie My goal is to bring this back ASAP, but until then we still have to get work done.

@KevinH-MS
Copy link
Contributor

Unfortunate, but if the experience is significantly better without the adapters present, we can probably figure out some other (nonstandard) way for Live Unit Testing to work. Sam, can you elaborate on the pain so I can follow up with the test platform team? Is it just CPU cycles when opening solution/building, or are there other problems?

@sharwell
Copy link
Member Author

@KevinH-MS Due to some issues in Test Explorer which are resolved but not yet shipped, we're experiencing high allocation rates which are resulting in pronounced GC-related usability problems. According to @davkean, these were measured in the range of ~1.5TiB of allocations.

@sharwell sharwell mentioned this pull request Jun 30, 2017
@ManishJayaswal
Copy link
Contributor

@sharwell - is there a bug tracking the TE window allocation issue that I can look at?

@tannergooding
Copy link
Member

@sharwell, I thought it was 3.5TB and we reduced it by 1.5TB

@davkean
Copy link
Member

davkean commented Jun 30, 2017 via email

@sharwell sharwell merged commit 6baa2b7 into dotnet:master Jul 3, 2017
@sharwell sharwell deleted the disable-test-explorer branch July 3, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-already-signed Contributor Pain The issue impedes progress for project collaborators.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants