Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconstruction on tuple literal doesn't emit ref to ValueTuple #22731

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Deconstruction on tuple literal doesn't emit ref to ValueTuple #22731

merged 1 commit into from
Oct 23, 2017

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Oct 17, 2017

Although the ValueTuple types are required for binding, the reference is not emitted. Adding a test to verify that.
Closes #22382

@jcouv jcouv added Area-Compilers Test Test failures in roslyn-CI labels Oct 17, 2017
@jcouv jcouv added this to the 15.later milestone Oct 17, 2017
@jcouv jcouv self-assigned this Oct 17, 2017
@jcouv
Copy link
Member Author

jcouv commented Oct 19, 2017

@gafter @dotnet/roslyn-compiler for review. Test-only change. Thanks

@jcouv
Copy link
Member Author

jcouv commented Oct 20, 2017

@cston See the previous PR (#20295) for (x, y) = e;. For such scenario we require no ValueTuple reference, even for binding.

@jcouv
Copy link
Member Author

jcouv commented Oct 23, 2017

I'll go ahead and merge with one review (test-only change). Thanks

@jcouv jcouv merged commit 9c90835 into dotnet:post-dev15.5-contrib Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers cla-already-signed Test Test failures in roslyn-CI
Projects
None yet
Milestone
15.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcouv @cston @dnfclas